Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to comment tensorboard #11362

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 14, 2023

πŸ€– Generated by Copilot at b638a20

Summary

Walkthrough

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Optional TensorBoard support in requirements and dynamic import for TensorBoard in logger.

πŸ“Š Key Changes

  • Commented out the TensorBoard requirement in requirements.txt to make the installation optional.
  • Changed the import style for TensorBoard's SummaryWriter in utils/loggers/__init__.py to only import if available, with a fallback to a lambda function returning None.

🎯 Purpose & Impact

  • Users who don't need TensorBoard can now install YOLOv5 with fewer dependencies, making the installation lighter and potentially resolving conflicts with the specific version of TensorBoard or protobuf.
  • The dynamic import means that TensorBoard is only a soft requirement. This could lead to fewer installation issues for users and a more flexible setup for specialized environments. Users who do not use TensorBoard won't notice any differences, while those who use it should ensure it's installed separately.

@glenn-jocher glenn-jocher changed the title Update requirements.txt comment tensorboard Update requirements.txt to comment tensorboard Apr 14, 2023
@glenn-jocher glenn-jocher merged commit 94714fe into master Apr 14, 2023
@glenn-jocher glenn-jocher deleted the remove_tensorboard branch April 14, 2023 22:51
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
* Update requirements.txt comment tensorboard

Signed-off-by: Glenn Jocher <[email protected]>

* Make tensorboard optional

* Update __init__.py

Signed-off-by: Glenn Jocher <[email protected]>

---------

Signed-off-by: Glenn Jocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant