Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change export.py workspace argument to MB instead of GB #6878

Closed
2 tasks done
DavidBaldsiefen opened this issue Mar 7, 2022 · 1 comment
Closed
2 tasks done

Change export.py workspace argument to MB instead of GB #6878

DavidBaldsiefen opened this issue Mar 7, 2022 · 1 comment
Labels
enhancement New feature or request Stale Stale and schedule for closing soon

Comments

@DavidBaldsiefen
Copy link
Contributor

Search before asking

  • I have searched the YOLOv5 issues and found no similar feature requests.

Description

Currently, export.py has a workspace argument to set the TensorRT workspace size in GB.

config.max_workspace_size = workspace * 1 << 30

However, many GPUs have memory that diverges slightly from the "GB" "rating". For example, a RTX3050 is advertised with 4GB but actually only has 3910MiB of memory. Similar things are true for many other cards. To ensure the user to be able to select a workspace size that reflects this reality, the workspace argument should accept memory sizes in MB

Use case

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@DavidBaldsiefen DavidBaldsiefen added the enhancement New feature or request label Mar 7, 2022
DavidBaldsiefen added a commit to DavidBaldsiefen/yolov5 that referenced this issue Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

👋 Hello, this issue has been automatically marked as stale because it has not had recent activity. Please note it will be closed if no further activity occurs.

Access additional YOLOv5 🚀 resources:

Access additional Ultralytics ⚡ resources:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐!

@github-actions github-actions bot added the Stale Stale and schedule for closing soon label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale Stale and schedule for closing soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant