Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-testing.yml #2303

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update ci-testing.yml #2303

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR updates the GitHub Actions workflow for better error notifications via Slack integration in the YOLOv3 project.

πŸ“Š Key Changes

  • Adjusted the Slack notification settings to use 'incoming-webhook' for error alerts.
  • Removed redundant environment variable declaration by directly using the secret in the payload configuration.

🎯 Purpose & Impact

  • Enhanced Notification: The change ensures better communication of CI failures to the development team via Slack, allowing for quicker response times. πŸ“’
  • Streamlined Configuration: Simplifies the Slack webhook configuration, reducing the potential for errors and improving maintainability. πŸ› οΈ

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov3 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov3 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🌟

This is an automated response, but rest assured, an Ultralytics engineer will review your PR soon. 😊

@glenn-jocher glenn-jocher merged commit 47a65e3 into master Nov 19, 2024
6 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants