Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyPI trusted publisher #244

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Use PyPI trusted publisher #244

merged 4 commits into from
Oct 16, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 16, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR modifies the workflow for publishing to PyPI by commenting out the existing secret-based authentication process.

πŸ“Š Key Changes

  • The line setting the PYPI_TOKEN for publishing to PyPI has been commented out.
  • Maintains the existing logic for checking if a version increment has occurred before publishing.

🎯 Purpose & Impact

  • Increased Security: By commenting out the secrets usage, it appears to be preparing the workflow for a more secure or alternative publishing method, potentially reducing risks associated with handling sensitive information.
  • No Immediate User Impact: These changes are internal to the GitHub Actions workflow and do not directly affect end-users but improve the backend process management.

@UltralyticsAssistant UltralyticsAssistant added dependencies Dependencies and packages enhancement New feature or request labels Oct 16, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting this pull request to the ultralytics/actions repository! πŸš€ This is an automated response to help guide you through the process, and an Ultralytics engineer will review it soon.

Here's a quick checklist to help ensure your PR gets integrated smoothly:

  • βœ… Purpose & Description: Please confirm the purpose of commenting out the PYPI_TOKEN in the publish.yml workflow file. It’s important to clearly outline this in your PR description for better understanding.
  • βœ… Main Branch Synchronization: Ensure your branch is up-to-date with the main branch by hitting 'Update branch' or using git pull and git merge main on your local setup.
  • βœ… Pass CI Checks: Check that all the CI checks have cleared. If any tests fail, addressing these would be beneficial. Check our CI documentation for guidance.
  • βœ… Documentation Updates: If your changes affect the workflow process significantly, please update or verify the associated documentation.
  • βœ… Testing: Consider adding or modifying tests to cover your changes, ensuring all existing tests pass seamlessly.
  • βœ… CLA Signature: If this is your first contribution, remember to sign our Contributor License Agreement by stating in a comment, "I have read the CLA Document and I sign the CLA".
  • βœ… Minimum Changes: Keep your modifications limited to just what's necessary for this update. As Bruce Lee said, "It is not daily increase but daily decrease, hack away the unessential."

You can always refer to our Contributing Guide for more insights. If you have any questions, please leave a comment in the PR thread. Thank you for your efforts to improve Ultralytics! πŸ™Œ

@glenn-jocher glenn-jocher changed the title Update publish.yml Use PyPI trusted publisher Oct 16, 2024
@glenn-jocher glenn-jocher merged commit e8a73d1 into main Oct 16, 2024
2 of 3 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch October 16, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies and packages enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants