This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 12
Feat: recursive dom profiler #96
Merged
blakebyrnes
merged 46 commits into
ulixee:main
from
soundofspace:feat--recursive-dom-profiler
Jun 17, 2024
Merged
Feat: recursive dom profiler #96
blakebyrnes
merged 46 commits into
ulixee:main
from
soundofspace:feat--recursive-dom-profiler
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soundofspace
force-pushed
the
feat--recursive-dom-profiler
branch
from
June 4, 2024 13:29
94e4eef
to
106364d
Compare
soundofspace
commented
Jun 11, 2024
soundofspace
commented
Jun 11, 2024
soundofspace
commented
Jun 11, 2024
soundofspace
commented
Jun 11, 2024
Are these flacky mitm tests or should these really be investigated, seems kinda consistent? |
blakebyrnes
reviewed
Jun 11, 2024
Flaky |
New changes look good. Some of these tests in the browser emulator/navigator will need an updated "cut" of the profile data to verify that they can modify objects to match the spec. |
Fixes #55 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main focus of this PR is improving profiler and default-browser-emulator:
_$otherInvocation
keysthis
object changes output of of function: egBluetooth.getAvailability
(illegal invocation) vsnavigator.bluetooth.getAvailability
(false or true)-
removeUnsupportedPropertiesFromPolyfill
to remove things that emulator currently doesn't support -> these should be added in the future (failed promise results, functions that require arguments)this
changes outputTest fixes:
Other things done: