This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
WIP: fix(agent): in page nav on unload #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakebyrnes
force-pushed
the
trailing-nav
branch
3 times, most recently
from
a0d5284 to
d354a18
Compare
chore: update typescript
blakebyrnes
force-pushed
the
trailing-nav
branch
from
d354a18 to
8f5ee9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a navigation occurs during unload of a page (or a next navigation), it's taking over the navigation history improperly. I think this observer needs to be reworked, but this fix will at least only make an in-page navigation "top" if it's for the same domain as the current top.
Since I don't have time to properly write unit tests, I'm putting this out here as a branch until I can do so.