Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Commit

Permalink
chore: up minimum profile versions
Browse files Browse the repository at this point in the history
  • Loading branch information
blakebyrnes committed Aug 30, 2024
1 parent 3a0f1c1 commit b8c8567
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 3 additions & 2 deletions browser-profiler/main/scripts/runBrowserstack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ export default async function runBrowserstack(): Promise<void> {
}

// too old for the double agent suite
if (browser.name === 'Firefox' && Number(browser.version.major) < 63) continue;
if (browser.name === 'Firefox' && Number(browser.version.major) < 100) continue;
// TODO: The dom environment plugin hangs <= 94. Need to investigate for scraper report eventually
if (browser.name === 'Chrome' && Number(browser.version.major) < 95) continue;
if (browser.name === 'Safari' && Number(browser.version.major) < 11) continue;
if (browser.name === 'Edge' && Number(browser.version.major) < 95) continue;
if (browser.name === 'Safari' && Number(browser.version.major) < 13) continue;
// no support for Promises, lambdas... detections need refactor for support
if (browser.name === 'IE') continue;

Expand Down
5 changes: 5 additions & 0 deletions browser-profiler/main/scripts/runBrowserstackDoms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ export default async function runBrowserstack(): Promise<void> {
continue;
}

if (browser.name === 'Firefox' && Number(browser.version.major) < 100) continue;
// TODO: The dom environment plugin hangs <= 94. Need to investigate for scraper report eventually
if (browser.name === 'Chrome' && Number(browser.version.major) < 95) continue;
if (browser.name === 'Edge' && Number(browser.version.major) < 95) continue;
if (browser.name === 'Safari' && Number(browser.version.major) < 13) continue;
// no support for Promises, lambdas... detections need refactor for support
if (browser.name === 'IE') continue;

// 1. Does this need to run? Clean up as needed.
const domDir = Path.join(baseDomsDir, `${userAgentId}--${features}`);
Expand Down

0 comments on commit b8c8567

Please sign in to comment.