Skip to content

Commit

Permalink
delete unused 04-channel version functions (cosmos#1636) (cosmos#1638)
Browse files Browse the repository at this point in the history
* delete unused code and associated tests

* Update CHANGELOG.md

(cherry picked from commit 6c4a442)

Co-authored-by: Carlos Rodriguez <[email protected]>
  • Loading branch information
2 people authored and ulbqb committed Jul 31, 2023
1 parent 46a0148 commit f24bc01
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 104 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (apps/27-interchain-accounts)[\#1565](https://github.com/cosmos/ibc-go/pull/1565) Removing `NewErrorAcknowledgement` in favour of `channeltypes.NewErrorAcknowledgement`.
* (transfer)[\#1565](https://github.com/cosmos/ibc-go/pull/1565) Removing `NewErrorAcknowledgement` in favour of `channeltypes.NewErrorAcknowledgement`.
* (channel)[\#1565](https://github.com/cosmos/ibc-go/pull/1565) Updating `NewErrorAcknowledgement` to accept an error instead of a string and removing the possibility of non-deterministic writes to application state.
* (core/04-channel)[\#1636](https://github.com/cosmos/ibc-go/pull/1636) Removing `SplitChannelVersion` and `MergeChannelVersions` functions since they are not used.

### State Machine Breaking

Expand Down
27 changes: 0 additions & 27 deletions modules/core/04-channel/types/version.go

This file was deleted.

77 changes: 0 additions & 77 deletions modules/core/04-channel/types/version_test.go

This file was deleted.

0 comments on commit f24bc01

Please sign in to comment.