fix: add template filter to correctly format the table name

uktrade · Oct 24, 2024 · 93370ee · 93370ee
1 parent c0a675d
commit 93370ee
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/dataworkspace/dataworkspace/apps/datasets/templatetags/datasets_tags.py b/dataworkspace/dataworkspace/apps/datasets/templatetags/datasets_tags.py
@@ -182,3 +182,8 @@ def saved_grid_config(user, source):
 @register.filter
 def timedelta_to_minutes(td):
     return round(td.total_seconds() / 60, 2)
+
+
+@register.filter
+def format_table_name(table_name):
+    return table_name.capitalize().replace("_", " ")
diff --git a/dataworkspace/dataworkspace/templates/datasets/details/sourceset_dataset.html b/dataworkspace/dataworkspace/templates/datasets/details/sourceset_dataset.html
@@ -117,11 +117,11 @@ <h2 class="govuk-heading-m">Data tables</h2>
                 {% if has_access %}
                   {% if source_table.data_grid_enabled %}
                   <a class="govuk-link" href="{% url "datasets:source_table_detail" dataset_uuid=dataset.id object_id=source_table.id %}">
-                    {{ source_table.name }}
+                    {{ source_table.name|format_table_name }}
                   </a>
                 {% endif %}
                 {% else %}
-                  {{ source_table.name }}
+                  {{ source_table.name|format_table_name }}
                 {% endif %}
               {% endif %}
             </td>

diff --git a/dataworkspace/dataworkspace/tests/datasets/test_datasets_tags.py b/dataworkspace/dataworkspace/tests/datasets/test_datasets_tags.py
@@ -0,0 +1,15 @@
+from dataworkspace.apps.datasets.templatetags.datasets_tags import format_table_name
+
+
+class TestFormatTableName:
+    def test_should_correctly_format_table_name(self):
+        test_cases = [
+            "This_Is_A_Table_Name",
+            "this_is_a_table_name",
+            "THIS_IS_A_TABLE_NAME",
+            "tHIS_iS_a_tABLE_nAME",
+            "This_is_a_table_name",
+        ]
+
+        for test in test_cases:
+            assert format_table_name(test) == "This is a table name"