Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Details not display summary label #40

Closed
mattkerlogue opened this issue Sep 21, 2019 · 5 comments
Closed

Details not display summary label #40

mattkerlogue opened this issue Sep 21, 2019 · 5 comments

Comments

@mattkerlogue
Copy link
Contributor

When I create a details block the summary label doesn't appear. Compare this Rmd with the html.

From a brief scan, I think line 45 of govuk.lua might not be right and that it should be calling i.attributes rather than el.attributes

pandoc.utils.stringify(el.attributes["summary"]) ..
@nacnudus
Copy link
Collaborator

nacnudus commented Oct 2, 2019

I can't reproduce the problem.

Has the html been rendered off that version of the Rmd? It has bullet points that aren't in the Rmd.

@nacnudus
Copy link
Collaborator

nacnudus commented Oct 22, 2019

Confirmed. Also on android chrome, where it can't even be opened.

image

@nacnudus
Copy link
Collaborator

Only confirmed on the Travis build. Maybe it's a bug in pandoc.utils.stringify() that has been fixed since version 2.2.1, which is what the default Travis distro seems to use, going by the log:

curl -fLo /tmp/pandoc-2.2-1-amd64.deb https://github.com/jgm/pandoc/releases/download/2.2/pandoc-2.2-1-amd64.deb

nacnudus added a commit that referenced this issue Oct 24, 2019
This might address #40 by installing a more recent version of pandoc than 2.2.1.
that doesn't have a bug in `pandoc.utils.stringify()`.
nacnudus added a commit that referenced this issue Nov 6, 2019
nacnudus added a commit that referenced this issue Nov 6, 2019
Having sorted out #40 by manually installing the latest version, downgrade again
to v2.0.3, which is the earliest v2 release, because v2 should be sufficient for
the lua filters.
nacnudus added a commit that referenced this issue Nov 6, 2019
nacnudus added a commit that referenced this issue Nov 6, 2019
nacnudus added a commit that referenced this issue Nov 6, 2019
@nacnudus
Copy link
Collaborator

nacnudus commented Nov 7, 2019

Well this has been fun. v2.7 works, and so do v2.6 and v2.5. Now what?

  • Require v2.5? But it seems to be hard enough for people to get v2.0.
  • Document the "details" component? People will only see that if they refer to the docs when writing their own page, but not when they inherit a page from someone else.
  • Write my own stringify 😩

@mattkerlogue as the main user, are you able to install pandoc v2.5+?

@nacnudus
Copy link
Collaborator

nacnudus commented Nov 8, 2019

Writing my own stringify to support old versions of Pandoc looks like a pain and isn't justified at the moment. Users are welcome to ask for it if they need it though.

@nacnudus nacnudus closed this as completed Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants