Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test to highlight issue #757 #758

Merged
merged 3 commits into from
Mar 5, 2021
Merged

new test to highlight issue #757 #758

merged 3 commits into from
Mar 5, 2021

Conversation

RemDelaporteMathurin
Copy link

@RemDelaporteMathurin RemDelaporteMathurin commented Mar 4, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

test to check whether it is the 'usual' construction error
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #758 (cecd088) into develop (cf27ff1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #758   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           72       72           
  Lines         4724     4724           
========================================
  Hits          4506     4506           
  Misses         218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf27ff1...cecd088. Read the comment docs.

@shimwell shimwell merged commit d1a5f26 into develop Mar 5, 2021
@shimwell shimwell deleted the bug_cut_spline_shapes branch March 5, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants