3388 update the beta limit section of the docs to be up to date and include all models #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation and type hints
…e the fast alpha pressure contribution into the plasma beta docs section
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3389 +/- ##
==========================================
- Coverage 29.65% 29.63% -0.03%
==========================================
Files 78 78
Lines 19090 19105 +15
==========================================
Hits 5661 5661
- Misses 13429 13444 +15 ☔ View full report in Codecov by Sentry. |
…across the codebase
chris-ashe
force-pushed
the
3388-update-the-beta-limit-section-of-the-docs-to-be-up-to-date-and-include-all-models
branch
from
0765fbe to
480b79d
Compare
… for clarity and consistency across the codebase
… for consistency across the codebase
…rmal beta calculations
…al beta calculation
…oidal and norm_beta_poloidal to update related calculations and references for consistency
…ion notes for clarity
…cs-to-be-up-to-date-and-include-all-models
…ses for clarity to account for new bootstrap scalings
…cs-to-be-up-to-date-and-include-all-models
…cs-to-be-up-to-date-and-include-all-models
…iles for consistency
… files for consistency
chris-ashe
force-pushed
the
3388-update-the-beta-limit-section-of-the-docs-to-be-up-to-date-and-include-all-models
branch
from
f79ed8f to
a3bc522
Compare
… and documentation
…s data files and scripts
chris-ashe
force-pushed
the
3388-update-the-beta-limit-section-of-the-docs-to-be-up-to-date-and-include-all-models
branch
from
6033ca5 to
63850d5
Compare
…cs-to-be-up-to-date-and-include-all-models
…cs-to-be-up-to-date-and-include-all-models
…a and create new variable e_plasma_beta_thermal
…ences throughout the code
…nergy calculations
chris-ashe
changed the title
j-a-foster
approved these changes
Jan 7, 2025
timothy-nunn
requested changes
Jan 7, 2025
| title="Menard Normalized Beta Limit", | ||
| ) | ||
| plot.xaxis.axis_label = r"Aspect ratio, \ $$[A]$$" | ||
| plot.yaxis.axis_label = r"Normalized beta limit, \ $$[\beta_N]$$" |
There was a problem hiding this comment.
Not sure your labels are working?
| title="Original Normalized Beta Limit", | ||
| ) | ||
| plot.xaxis.axis_label = r"Aspect ratio, \ $$[A]$$" | ||
| plot.yaxis.axis_label = r"Normalized beta limit, \ $$[\beta_N]$$" |
There was a problem hiding this comment.
As above, labels are not rendering properly
timothy-nunn
approved these changes
Jan 7, 2025
timothy-nunn
deleted the
3388-update-the-beta-limit-section-of-the-docs-to-be-up-to-date-and-include-all-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace changes
Functions
culblm()->calculate_beta_limit()Variables
betaft->beta_fast_alphaiculbl->i_beta_componentbetalim->beta_maxbetalim_lower->beta_minbetpmx->beta_poloidal_maxfbetap->fbeta_poloidalbetap->beta_poloidalbetat->beta_toroidal: Added now as a proper physics variable that can be seen in outputbetath->beta_thermal: Added now as a proper physics variable that can be seen in outputtotal_plasma_internal_energy->e_plasma_betaNew additions
beta_toroidal: Was originally calculated but never set to a variablebeta_thermal: Was originally calculated but never set to a variablebeta_thermal_poloidal: Was originally calculated but never set to a variablebeta_thermal_toroidal: Was originally calculated but never set to a variablebeta_norm_thermal: Was originally calculated but never set to a variablebeta_norm_toroidal: Was originally calculated but never set to a variablebeta_norm_poloidal: Was originally calculated but never set to a variablebeta_norm_total: Was originally calculated but never set to a variablee_plasma_beta_thermal: The value of the plasma thermal energy derived from the thermal beta was calculated yet never set to a variable.Output
Before
After
🐛 Bugs
normalised_total_betawas set as a variable but not put to outputChecklist
I confirm that I have completed the following checks: