Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced local calculated eps variable with fortran variable as input #3102

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Mar 14, 2024

Replaced inverse aspect ratio calculated locally in _plascar_bpol with input eps which is the fortran variable physics_variables.eps in subsequest functions which use _plascar_bpol. These functions are bpol and plasc.

Closes #454

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Mar 14, 2024 that may be closed by this pull request
@j-a-foster
Copy link
Collaborator Author

Unsure whether need to change physics.py line 751 as it's calculated on an index by index basis. It's also not clear from the docstring/comments whether this eps corresponds to the eps mentioned in #454.

@mkovari mkovari merged commit 078bf1a into main Mar 14, 2024
20 checks passed
@mkovari mkovari deleted the 454-eps-inverse-aspect-ratio branch March 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eps - inverse aspect ratio
2 participants