Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy, scipy, numba version requirements #3100

Conversation

timothy-nunn
Copy link
Contributor

@timothy-nunn timothy-nunn commented Mar 13, 2024

Description

Updates and consolidates some of our requirements for external packages to:

  1. Avoid issues with numba < 0.57.
  2. Simplify and update some of our versions, specifically our numpy versions.

Closes #1774 (I think?)

@timothy-nunn timothy-nunn linked an issue Mar 13, 2024 that may be closed by this pull request
@timothy-nunn timothy-nunn marked this pull request as ready for review March 13, 2024 15:27
@timothy-nunn timothy-nunn requested a review from jonmaddock March 13, 2024 15:27
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This made me think of #1527, which might have caught this problem on the CI/made it possible to switch to a development install and get a working version.

@jonmaddock jonmaddock merged commit 209278a into main Mar 13, 2024
20 checks passed
@jonmaddock jonmaddock deleted the 3099-numba-typingerror-when-running-large-tokamak-regression-test branch March 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numba TypingError when running large-tokamak regression test PROCESS build error if default numpy is used
2 participants