-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2980 create availability model for spherical tokamaks #3039
Merged
j-a-foster
merged 15 commits into
main
from
2980-create-availability-model-for-spherical-tokamaks
Feb 1, 2024
Merged
2980 create availability model for spherical tokamaks #3039
j-a-foster
merged 15 commits into
main
from
2980-create-availability-model-for-spherical-tokamaks
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-ashe
reviewed
Jan 30, 2024
This reverts commit fb10173. Reversing commit above to correct autoformatting inserting unwanted changes.
chris-ashe
reviewed
Jan 31, 2024
chris-ashe
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model has been discussed and checked to be correct and is well documented with correct formatting.
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Added CP lifetime routine to remove duplicated code * Added variables for avail_st model * Added avail_st model and tests * Added error if itart not set to ST * Added relevant flux and fluence outputs and CP lifetime * Revert "Added variables for avail_st model" This reverts commit fb10173. Reversing commit above to correct autoformatting inserting unwanted changes. * Readded new variables for ST availability model * Flake8 fixes * Updated docstrings * Renamed plant.md to plant-availability.md * Added docs for ST availability model and CP lifetime calculation * Updated yaml so docs generate correctly * Fixed table in plant availability docs * Minor changes to docs * Minor changes to docs
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
* Added CP lifetime routine to remove duplicated code * Added variables for avail_st model * Added avail_st model and tests * Added error if itart not set to ST * Added relevant flux and fluence outputs and CP lifetime * Revert "Added variables for avail_st model" This reverts commit fb10173. Reversing commit above to correct autoformatting inserting unwanted changes. * Readded new variables for ST availability model * Flake8 fixes * Updated docstrings * Renamed plant.md to plant-availability.md * Added docs for ST availability model and CP lifetime calculation * Updated yaml so docs generate correctly * Fixed table in plant availability docs * Minor changes to docs * Minor changes to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: