Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2980 create availability model for spherical tokamaks #3039

Merged

Conversation

j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Jan 30, 2024

Description

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Jan 30, 2024 that may be closed by this pull request
@j-a-foster j-a-foster requested a review from chris-ashe January 30, 2024 11:32
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model has been discussed and checked to be correct and is well documented with correct formatting.

@j-a-foster j-a-foster merged commit 93ec17f into main Feb 1, 2024
20 checks passed
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
* Added CP lifetime routine to remove duplicated code

* Added variables for avail_st model

* Added avail_st model and tests

* Added error if itart not set to ST

* Added relevant flux and fluence outputs and CP lifetime

* Revert "Added variables for avail_st model"

This reverts commit fb10173.

Reversing commit above to correct autoformatting inserting unwanted changes.

* Readded new variables for ST availability model

* Flake8 fixes

* Updated docstrings

* Renamed plant.md to plant-availability.md

* Added docs for ST availability model and CP lifetime calculation

* Updated yaml so docs generate correctly

* Fixed table in plant availability docs

* Minor changes to docs

* Minor changes to docs
chris-ashe pushed a commit that referenced this pull request May 1, 2024
* Added CP lifetime routine to remove duplicated code

* Added variables for avail_st model

* Added avail_st model and tests

* Added error if itart not set to ST

* Added relevant flux and fluence outputs and CP lifetime

* Revert "Added variables for avail_st model"

This reverts commit fb10173.

Reversing commit above to correct autoformatting inserting unwanted changes.

* Readded new variables for ST availability model

* Flake8 fixes

* Updated docstrings

* Renamed plant.md to plant-availability.md

* Added docs for ST availability model and CP lifetime calculation

* Updated yaml so docs generate correctly

* Fixed table in plant availability docs

* Minor changes to docs

* Minor changes to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create availability model for spherical tokamaks
2 participants