Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot dat opt dat removal #3021

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Plot dat opt dat removal #3021

merged 5 commits into from
Jan 11, 2024

Conversation

clmould
Copy link
Collaborator

@clmould clmould commented Jan 11, 2024

Description

Closes #3015
PLOT.DAT and OPT.DAT files were created during a PROCESS run but were empty and unused so stopping these from being created and removing references to them in documentation.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Jan 11, 2024 that may be closed by this pull request
@clmould clmould self-assigned this Jan 11, 2024
@clmould clmould requested a review from timothy-nunn January 11, 2024 11:42
@clmould clmould marked this pull request as ready for review January 11, 2024 13:37
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clmould all looks good to me, just one fix thats my fault and one QOL change

examples/a_scan_input_file_IN.DAT Outdated Show resolved Hide resolved
examples/a_scan_input_file_IN.DAT Outdated Show resolved Hide resolved
@clmould clmould requested a review from timothy-nunn January 11, 2024 15:52
@timothy-nunn timothy-nunn merged commit 5504b6c into main Jan 11, 2024
20 checks passed
@timothy-nunn timothy-nunn deleted the plot-dat-opt-dat-removal branch January 11, 2024 16:16
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
* stop opt.dat being created and remove references to it in docs

* remove references to plot.dat in documentation

* stop data being written to plot.dat and stop plot.dat being produced

also remove comment referencing now-deleted plot_dat function

also add points for 2d scan to example scan input file

* tidy up example scan input file based on review comments
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
* stop opt.dat being created and remove references to it in docs

* remove references to plot.dat in documentation

* stop data being written to plot.dat and stop plot.dat being produced

also remove comment referencing now-deleted plot_dat function

also add points for 2d scan to example scan input file

* tidy up example scan input file based on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLOT.DAT & OPT.DAT seem to now be redundant and never used
2 participants