Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vacuum vessel docs #3000

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix vacuum vessel docs #3000

merged 2 commits into from
Nov 29, 2023

Conversation

clmould
Copy link
Collaborator

@clmould clmould commented Nov 27, 2023 •
edited
Loading

Description

#2995
Fixes vacuum vessel docs, fixes displaying of images and adds link to page in navbar

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Nov 27, 2023 that may be closed by this pull request
[BUG] Images in vacuum vessel docs page not displaying and page not in navbar #2995
Closed
@clmould clmould marked this pull request as ready for review November 27, 2023 13:39
@clmould clmould requested a review from timothy-nunn November 27, 2023 13:39
timothy-nunn
timothy-nunn requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $\theta_1$ looks better with the subscript (I may have missed some in the suggestions). Other than that, it all looks good, thanks for spotting this and fixing it!

documentation/proc-pages/eng-models/vacuum-vessel.md Outdated Show resolved Hide resolved
documentation/proc-pages/eng-models/vacuum-vessel.md Outdated Show resolved Hide resolved
documentation/proc-pages/eng-models/vacuum-vessel.md Outdated Show resolved Hide resolved
documentation/proc-pages/eng-models/vacuum-vessel.md Outdated Show resolved Hide resolved
@clmould clmould force-pushed the 2995-bug-images-in-vacuum-vessel-docs-page-not-displaying-and-page-not-in-navbar branch from 830f67d to c9af228 Compare November 29, 2023 11:32
@clmould clmould requested a review from timothy-nunn November 29, 2023 11:33
@timothy-nunn timothy-nunn merged commit e75276e into main Nov 29, 2023
20 checks passed
@timothy-nunn timothy-nunn deleted the 2995-bug-images-in-vacuum-vessel-docs-page-not-displaying-and-page-not-in-navbar branch November 29, 2023 11:50
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@clmould @chris-ashe
Fix vacuum vessel docs (#3000)
c14a7a9 
* fix spelling of vessel

* fix VV docs and add to navbar
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@clmould @chris-ashe
Fix vacuum vessel docs (#3000)
c0696b8 
* fix spelling of vessel

* fix VV docs and add to navbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Images in vacuum vessel docs page not displaying and page not in navbar
2 participants
@clmould @timothy-nunn