add blender image file and add it to README #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmaddock
reviewed
Sep 18, 2023
There was a problem hiding this comment.
This is a good start Clair: this is just what we wanted. Could you check with Oli that these are the best images we have at the moment, and if there are any other views we should include (i.e. the side-by-side Process and Bluemira design view). If not, then I'm happy with this!
README.md
Outdated
| @@ -5,6 +5,8 @@ PROCESS is the reactor systems code at the [UK Atomic Energy Authority](https:// | |||
|
|
|||
| PROCESS was originally a Fortran code, but is currently a mixture of Python and Python-wrapped Fortran; the eventual aim is to have an entirely Python code base. In order to use PROCESS, the Fortran must be compiled and a Python-Fortran interface generated for the Python to import. Once built, it can be installed and run as a Python package. | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Minor: could this go into images instead or blenderimages? We might well have more non-blender images in future.
clmould
force-pushed
the
2922-add-blender-images-to-readme
branch
from
abedd5d to
23fae51
Compare
clmould
changed the title
clmould
commented
Oct 13, 2023
jonmaddock
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added blender generated image of reactor to the README
Checklist
I confirm that I have completed the following checks: