Apply pulse parameters #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregordecristoforo
requested changes
May 12, 2023
|
I updated the Readme a little bit, not sure how much detail you want in there: I think the code was supposed to still work as it was working before this MR. |
gregordecristoforo
requested changes
May 16, 2023
README.md
Outdated
| @@ -109,6 +108,8 @@ Alternatively, you can specify all blob parameters exactly as you want by writin | |||
| `free_parameter` for vx | |||
| - `vy_parameter`: float, optional, | |||
| `free_parameter` for vy | |||
| - `spx_parameter`: float = 0.5, | |||
There was a problem hiding this comment.
You forgot to change the variable name here. Also, remove trailing ,
There was a problem hiding this comment.
it is still spx_parameter in the constructor, thought of leaving it short since the others are also shortened (A_dist, etc) and changing them will make old code not work.
There was a problem hiding this comment.
Should I have long name for the shape parameter arguments while keeping short name for the others?
There was a problem hiding this comment.
Well, that's what I've done now anyway
gregordecristoforo
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.