2d shape #54
Merged
2d shape #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregordecristoforo
requested changes
Mar 16, 2023
blobmodel/model.py
Outdated
| ), | ||
| ) | ||
| return start, stop | ||
| return 0, self._geometry.t.size |
There was a problem hiding this comment.
this is equivalent to the blob.v_x==0 case. We could reduce a level of indentation by writing:
if blob_v_x == 0 or not speed_up:
return 0, self._geometry.t_size
speed_up code
what do you think?
| f"{self.__class__.__name__}.blob_shape not implemented" | ||
| ) | ||
| theta_x = x_diffs / self.width_prop | ||
| return self.blob_shape.get_pulse_shape_prop(theta_x, ...) |
There was a problem hiding this comment.
... serves as a placeholder for kwargs right?
|
Ok, once the test pass I think it's ready to be merged |
gregordecristoforo
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53