42 implement individual labels for individual blobs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregordecristoforo
requested changes
Apr 12, 2022
blobmodel/model.py
Outdated
| @@ -53,6 +54,8 @@ def __init__( | |||
| label_border: float, optional | |||
| defines region of blob as region where density >= label_border * amplitude of Blob | |||
| only used if labels = True | |||
| label_type: str, optional | |||
There was a problem hiding this comment.
label_type and labels can be combined to one attribute
blobmodel/model.py
Outdated
| @@ -127,6 +131,11 @@ def make_realization( | |||
| t_drain=self.t_drain, | |||
| ) | |||
|
|
|||
| amp = [] | |||
There was a problem hiding this comment.
make amp a protected member by changing it to _amp
blobmodel/model.py
Outdated
| self._labels_field[:, :, _start:_stop][ | ||
| _single_blob | ||
| >= __max_amplitudes * self._label_border | ||
| + self._density[:, :, _start:_stop] * 0.25 |
There was a problem hiding this comment.
I don't understand the point of this line, please provide an explanation of the different options of label_type
gregordecristoforo
approved these changes
Apr 13, 2022
gregordecristoforo
deleted the
42-implement-individual-labels-for-individual-blobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.