Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mglaman/drupal-check to ^1.4 in test composer.json and make code updates #4

Open
3 tasks
pyrello opened this issue Aug 18, 2022 · 0 comments
Open
3 tasks
Labels
enhancement New feature or request

Comments

@pyrello
Copy link
Contributor

pyrello commented Aug 18, 2022

Motivation

As part of #2, we sidestepped this issue by specifically pinning to a version of mglaman/drupal-check to less than 1.4, which is the version that introduces changes to the checking that will necessitate code updates for tests to continue passing.

Proposed solution

  • Update mglaman/drupal-check to ^1.4 in the test composer.json.
  • Run drupal-check command locally.
  • Make code updates based on recommendations.
@pyrello pyrello added the enhancement New feature or request label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant