Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove problematic dependency injection #2

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Remove problematic dependency injection #2

merged 13 commits into from
Aug 18, 2022

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Aug 17, 2022

Resolves #1

@pyrello
Copy link
Contributor Author

pyrello commented Aug 17, 2022

I'm not sure why the build is erroring now. I'm trying to set mglaman/drupal-check to be less than 1.4. This seems to not be working.

@joewhitsitt
Copy link
Contributor

Sorry, I missed what you are trying to pin it at (besides less than 1.4). 1.3.2?

@pyrello
Copy link
Contributor Author

pyrello commented Aug 18, 2022

I'm only trying to pin it at less than 1.4

@joewhitsitt
Copy link
Contributor

Locally, I got:
- Installing mglaman/drupal-check (1.3.2): Extracting archive
Using: "mglaman/drupal-check": "~1.3.1",

@pyrello
Copy link
Contributor Author

pyrello commented Aug 18, 2022

I got it to pass!

@pyrello pyrello requested a review from a team August 18, 2022 14:44
joewhitsitt
joewhitsitt approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@joewhitsitt joewhitsitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, not tested. Wonder if once this is in uiowa, we can test in DEV?

@pyrello
Copy link
Contributor Author

pyrello commented Aug 18, 2022

Reviewed, not tested. Wonder if once this is in uiowa, we can test in DEV?

It will get tested in dev because I'm going to update it in the WhitmanWeb PR :)

@pyrello pyrello merged commit 0f9fb39 into main Aug 18, 2022
@pyrello pyrello deleted the remove_circular_dependency_injection branch August 18, 2022 18:08
@pyrello pyrello mentioned this pull request Aug 18, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewhitsitt joewhitsitt joewhitsitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This module prevents being able to install config_translation module because of circular reference error
2 participants
@pyrello @joewhitsitt