feat: improve performance of websocket message processing

[bdraco]

Description of change

Make the calls to the object type lookups normal attributes to avoid the function calls

Summary by CodeRabbit

• Refactor

  • Improved handling of bootstrap model types and models to enhance code maintainability and performance.

• Bug Fixes

  • Suppressed attribute definition warnings to ensure smoother code execution.

• Tests

  • Updated test cases to reflect changes in the iteration method for bootstrap models.

These changes are internal and should not affect the end-user experience directly.

[coderabbitai]

Walkthrough

In this update, the primary change involves refactoring how bootstrap model types and sets are accessed and iterated over within the ModelType class and various related functions. Specifically, class methods are now used to initialize class attributes, and the syntax for accessing these attributes has been updated across multiple files. Additionally, type ignore comments were added to suppress warnings about attribute definitions.

Changes

File	Change Summary
src/uiprotect/data/bootstrap.py	Updated iteration over ModelType bootstrap models and types with type ignores.
src/uiprotect/data/types.py	Refactored ModelType class to use class methods for initializing attributes and added immutability enforcement.
tests/data/test_common.py	Modified loop iteration to access ModelType.bootstrap_models without parentheses.

Poem

In code we dance, a rabbit's cheer,
Refactor paths, now crystal clear.
No mutable calls, just class-wide grace,
Bootstrap through sets, each in its place.
In the warren of bytes, we stand in awe,
Celebrating code—no single flaw.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Files	Coverage Δ
src/uiprotect/data/types.py	97.97% <96.15%> (+0.03%)	⬆️
src/uiprotect/data/bootstrap.py	55.01% <66.66%> (ø)

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9b6ab01 and b7c34a9.

Files selected for processing (3)

• src/uiprotect/data/bootstrap.py (4 hunks)
• src/uiprotect/data/types.py (3 hunks)
• tests/data/test_common.py (1 hunks)

Additional comments not posted (10)

src/uiprotect/data/types.py (6)

112-116: Class attributes for model sets are now directly accessible, which should improve performance by avoiding method calls.

---

148-151: Efficient use of a generator expression inside the tuple constructor.

---

155-157: Direct conversion of a tuple to a set is straightforward and efficient.

---

160-162: Direct conversion of a tuple to a set is straightforward and efficient.

---

165-167: Efficient use of set union to include the event model.

---

169-170: Correctly raises an AttributeError to enforce immutability of class attributes.

src/uiprotect/data/bootstrap.py (3)

196-197: Iterates over a set of model types directly, aligning with the PR's goal to improve performance by using attribute access instead of function calls.

---

233-234: Iterates over a set of model types directly, aligning with the PR's goal to improve performance by using attribute access instead of function calls.

---

553-553: Checks if the model type is in a set that includes both model types and the event model, aligning with the PR's goal to improve performance by using attribute access instead of function calls.

tests/data/test_common.py (1)

312-312: Ensure that the iteration over ModelType.bootstrap_models directly accesses the class attribute as per the PR's objective.