Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pushStateLocation] The url() method does not trigger a sync() in urlRouter #23

Closed
elboman opened this issue Jan 10, 2017 · 0 comments · Fixed by #24
Closed

[pushStateLocation] The url() method does not trigger a sync() in urlRouter #23

elboman opened this issue Jan 10, 2017 · 0 comments · Fixed by #24
Labels
bug

Comments

@elboman
Copy link
Member

elboman commented Jan 10, 2017

In pushStateLocation plugin, when setting a url with .url() the change listeners are not called therefore the router is not synced as expected.
@elboman elboman added the bug label Jan 10, 2017
This was referenced Jan 10, 2017
Merged
Closed
christopherthielen pushed a commit that referenced this issue Jan 14, 2017
@elboman @christopherthielen
fix(pushStateLocation): call listeners in url() (#24)
7c90911 
call all event listeners in url() after pushing/replacing the history state to correctly sync the router

Closes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pushStateLocation): call listeners in url() elboman/core
1 participant
@elboman