Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Refactor URL encoding/decoding and string types #14

Closed
christopherthielen opened this issue Dec 16, 2016 · 0 comments
Closed

Comments

@christopherthielen
Copy link
Member

christopherthielen commented Dec 16, 2016

The URL parsing code currently has some vestiges from when it only worked with the angular 1 $location service.

The ng1 $location service has one major flaw we could never work around. This was the reason the custom ~2F encoding was created (when encoding parameter values with slashes in them).

Goals:

  • ui-router-core should not have special handling for encoding slashes
  • angular-ui-router itself should encode slashes as ~2F
    • only in path parameter values
    • The string type currently process ~2F; rename this type to path and make it the default parameter type for path parameters in ng1 only
  • Move LocationService and LocationConfig from coreservices to UIRouter instance

BREAKING CHANGE

  1. Slashes in param values no longer encode to ~2F except for ng1 path params
  2. coreservices.location moved to UIRouter.location.service and UIRouter.location.config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant