Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uiSrefStatus): emit state/params in events #142

Merged
merged 1 commit into from
Sep 19, 2017
Merged

feat(uiSrefStatus): emit state/params in events #142

merged 1 commit into from
Sep 19, 2017

Conversation

gcca
Copy link
Contributor

@gcca gcca commented Jul 15, 2017

Add the sref target to the SrefStatus event.

Fixes #41

@gcca
Copy link
Contributor Author

gcca commented Sep 10, 2017

@christopherthielen I wonder if to add srefTarget instead of just the identifier could be more helpul in the line 123.

@christopherthielen
Copy link
Member

@gcca yeah, I think target makes more sense than just identifier

@christopherthielen christopherthielen merged commit bd67d25 into ui-router:master Sep 19, 2017
christopherthielen added a commit that referenced this pull request Sep 19, 2017
@christopherthielen
feat(uiSrefStatus): Emit all enclosed uiSref targetStates in the stat…
0687e19 
…us object

Closes #142
@christopherthielen
Copy link
Member

christopherthielen commented Sep 19, 2017 •
edited
Loading

Nice work. I updated it to emit an array of targets (UISrefActive can enclose multiple UISref) and renamed to targetStates 0687e19

@gcca gcca deleted the emit-stateparams branch September 19, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcca @christopherthielen