React18 support #34
Merged
React18 support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VFC is get obsolete and now FC is it
React says, the child of `ReactPortal` should be ReactNode ``` Type 'FunctionComponentElement<never>' is not assignable to type 'ReactNode'. Property 'children' is missing in type 'FunctionComponentElement<never>' but required in type 'ReactPortal'.ts(2322) ```
hachibeeDI
commented
May 27, 2022
| @@ -33,7 +33,7 @@ describe("Link", () => { | |||
| renderInHistory(history, <Component />); | |||
| expect(screen.queryByText("I AM BAR")).toBeNull(); | |||
| expect(history.index).toBe(0); | |||
| screen.queryByTestId("link")?.click(); | |||
| fireEvent.click(screen.queryByTestId("link")!); | |||
There was a problem hiding this comment.
I just abbused non-null assertion. Let me know if you prefer decent null check condition for that.
uhyo
approved these changes
May 29, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is actually "support @types/react-18"...
Issue
In my environment, RoconRoot claims the error like below:
packge.json:
What is this PR contains
Cheers!