Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grules files downloaded from Google Drive are occasionally empty #2

Closed
uhppoted opened this issue Apr 22, 2022 · 1 comment
Closed

Grules files downloaded from Google Drive are occasionally empty #2

uhppoted opened this issue Apr 22, 2022 · 1 comment
Assignees
@twystd

Comments

@uhppoted
Copy link
Owner

As of 2022-04-19, the HTTP GET used to fetch a grule file from Google Drive intermittently receives an empty file without an accompanying error.

Grule file handling needs to be reworked to verify the file is a grule file without requiring it contain any rules.
twystd added a commit that referenced this issue Apr 22, 2022
@twystd
Added mandatory header/footer to grules files as a basic validity che…
501eace 
…ck (Ref. #2)
twystd added a commit that referenced this issue Apr 22, 2022
@twystd
Updated README for grules file changes (Ref. #2)
174eaae
@uhppoted
Copy link
Owner Author

uhppoted commented Apr 22, 2022 •
edited by twystd
Loading

  1. Added mandatory grules file start and end markers
  2. Stashed good grules_ files to the workdir
  3. Fell back to the stashed grules file if the downloaded file is invalid (missing the start/end markers)
  4. Updated README

grules files are now required to have the following headers and footers:

// *** GRULES
..
..
// *** END GRULES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twystd twystd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twystd @uhppoted