Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make STARTTLS LDAP option more precise on UI #132

Merged
merged 10 commits into from
Apr 26, 2023

Conversation

TuringTux
Copy link
Contributor

@TuringTux TuringTux commented Apr 22, 2023

Closes #129.

This also attempts to provide Spanish and French translations, however, they should ideally be reviewed by someone with better knowledge of those languages.

@TuringTux
Copy link
Contributor Author

TuringTux commented Apr 22, 2023

I have manually changed the string in the .php file and in one translation file (authorizer.pot), however, that translation file seems to be automatically generated, so I probably need to try doing this with POedit.

Edit: Done. Running Poedit changed quite a lot in the .pot file, but I only committed the changes relevant to this proposal.

@TuringTux TuringTux marked this pull request as ready for review April 22, 2023 17:53
@figureone figureone merged commit 3052244 into uhm-coe:master Apr 26, 2023
@figureone
Copy link
Member

This looks great, thanks so much! It will be included in the next release

@figureone
Copy link
Member

Re: Poedit, I'm running a pretty old version myself and I think a lot of the formatting of the .pot output has changed between versions. Thanks for trimming that down to just the relevant changes, makes the code review easier!

@TuringTux TuringTux deleted the make-starttls-options-more-precise branch April 26, 2023 06:14
@TuringTux
Copy link
Contributor Author

Thank you for merging!

Yes, that is also what I suspected. I apologize for the bigger Spanish and French translation files, they are not trimmed to the max, because I had to update them from the .pot file and then somewhat lost track over the changes.

@figureone
Copy link
Member

Aloha, version 3.6.3 has now been released. Thanks so much for your contribution!

@TuringTux
Copy link
Contributor Author

That's very nice, thank you! I've just checked it and our production WordPress instance has already updated to the latest version, looks very nice indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make STARTTLS LDAP option more precise on UI
2 participants