-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy selection capability #117
Add proxy selection capability #117
Conversation
…hen authenticating with a CAS server.
This looks great, thanks so much for your contribution! We'll review this week and let you know if we have any comments before merging. Do you have a wordpress.org username so that we can add you to the list of Contributors? |
You're very welcome, happy to contribute! Excited to hear what comes from the review, good or bad. Here is my wordpress.org username |
One thing I should have mentioned, I defaulted the |
Aloha, looks really good! I made a few small changes, can you "Allow edits from maintainers" so I can push the commits to your pull request branch? Instructions here: (Edit: never mind! GitHub Desktop told me I didn't have access, but I pushed the commits below successfully.) |
We're releasing version 3.4.1 right now with your addition. Please let us know if you run into any issues. Thanks again, excellent work! |
Hello, Thank you for reviewing the changes and for listing me as a contributor. I've reviewed the additional changes you made to be better prepared for any future changes we may suggest. I will leave my branch open until I've had a chance to deploy and test it using the WP plugin update feature. Thanks again! |
The organization I work for is using your WP Plugin. However, for it to work with our CAS server, we had to change a line of code in the
class-authentication.php
file that dealt with interfacing with a CAS server. Adding this customization prevented us from using the WP plugin update feature because it would overwrite our changes anytime Authorizer was updated.I'm proposing this pull request that allows for a WP admin to choose how to interface with a CAS server, either over Proxy or using the Client method (see commits). I also added help documentation. These are demonstrated in the screenshots below. I have a limited understanding/knowledge of Authorizer and how CAS works, but did my best to add this functionality. Please feel free to share feedback as needed.
Option shown to WP Admin in the "External" tab of Authorizer:
Help documentation: