Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Switching not longer working with Authorizer Version 2.9.11 #91

Closed
ocager opened this issue Feb 14, 2020 · 4 comments
Closed

User Switching not longer working with Authorizer Version 2.9.11 #91

ocager opened this issue Feb 14, 2020 · 4 comments

Comments

@ocager
Copy link

ocager commented Feb 14, 2020

Hi,

since the release 2.9.11, the plugin User Switching is no longer working (more information about the behavior here). I've tested previously available versions from 2.8.8 to 2.9.11 and can confirm that the problem started with the current version (2.9.11). For the first time, I thought the reason is the plugin User Switching itself, but after a further investigation, I found out that the issue is linked to Authorizer.

Following your change log for version 2.9.11, there were many changes included, but I'm not the technical expert to identify if that behavior is wanted or not. Do you have an idea why User Switching is not working?

Regards
oca

@figureone
Copy link
Member

WordPress version 5.3 changed the behavior of the wp_logout filter, which caused us to switch to clear_auth_cookie to be able to log out CAS users:
586eebc

Here's the trac ticket about it:
https://core.trac.wordpress.org/ticket/35488#comment:11

And one of our support requests:
https://wordpress.org/support/topic/logout-does-not-work-2/

Can you try editing class-wp-plugin-authorizer.php as shown above to switch back to the wp_logout filter and see if that's the cause? If so, we'll need to investigate what User Switching is doing to change the current user.

@ocager
Copy link
Author

ocager commented Feb 17, 2020

Can you try editing class-wp-plugin-authorizer.php as shown above to switch back to the wp_logout filter and see if that's the cause? If so, we'll need to investigate what User Switching is doing to change the current user.

I can confirm that changing back to wp_logout filter recovers the functionality of the plugin User Switching.

figureone added a commit that referenced this issue Feb 25, 2020
to ensure compatibility with the User Switching plugin that relies on the logout routines not firing in clear_auth_cookie.
#91 (comment)
@figureone
Copy link
Member

Aloha, version 2.9.12 is out now with a fix, please test to see if it works for you.

@ocager
Copy link
Author

ocager commented Feb 26, 2020

Hi Paul, I installed the new version and tested successfully. Thanks a lot for the quick reaction and fix. Best!

@ocager ocager closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants