Merge pull request #1284 from uhafner/enable-revapi

Fix RevAPI versions configuration
uhafner · Jan 7, 2025 · 3dc1088 · 3dc1088
2 parents 501278f + ff5833b
commit 3dc1088
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 31 deletions.
diff --git a/.github/workflows/quality-monitor.yml b/.github/workflows/quality-monitor.yml
@@ -88,6 +88,17 @@ jobs:
                     }
                   ]
                 },
+                {
+                  "name": "API Problems",
+                  "id": "api",
+                  "icon": "no_entry_sign",
+                  "tools": [
+                    {
+                      "id": "revapi",
+                      "sourcePath": "src/main/java"
+                    }
+                  ]
+                },
                 {
                   "name": "Vulnerabilities",
                   "id": "vulnerabilities",

diff --git a/pom.xml b/pom.xml
@@ -964,7 +964,6 @@
         <groupId>org.revapi</groupId>
         <artifactId>revapi-maven-plugin</artifactId>
         <configuration>
-          <skip>true</skip>
           <versionFormat>[-0-9.]*</versionFormat>
           <failBuildOnProblemsFound>true</failBuildOnProblemsFound>
           <checkDependencies>true</checkDependencies>
@@ -982,43 +981,20 @@
               <attachments>
                 <vetted>ok</vetted>
               </attachments>
-              <differences>
-                <item>
-                  <ignore>true</ignore>
-                  <regex>true</regex>
-                  <code>java.annotation.*</code>
-                  <annotationType>edu.umd.cs.findbugs.annotations.*</annotationType>
-                  <justification>Annotation should be safe to change</justification>
-                </item>
-              </differences>
             </revapi.differences>
             <revapi.versions>
-              <versionIncreaseAllows>
-                <major>
-                  <severity>BREAKING</severity>
-                  <attachments>
-                    <vetted>ok</vetted>
-                  </attachments>
-                </major>
-                <minor>
-                  <severity>NON_BREAKING</severity>
-                  <attachments>
-                    <vetted>ok</vetted>
-                  </attachments>
-                </minor>
-                <patch>
-                  <severity>EQUIVALENT</severity>
-                  <attachments>
-                    <vetted>ok</vetted>
-                  </attachments>
-                </patch>
-              </versionIncreaseAllows>
+              <enabled>true</enabled>
+              <strictSemver>false</strictSemver>
+              <onAllowed>
+                <criticality>documented</criticality>
+                <justification>Allowed by the rules of semantic versioning.</justification>
+              </onAllowed>
             </revapi.versions>
             <revapi.reporter.json>
               <minSeverity>NON_BREAKING</minSeverity>
               <minCriticality>documented</minCriticality>
               <output>${project.build.directory}/revapi-result.json</output>
-              <indent>false</indent>
+              <indent>true</indent>
               <append>false</append>
               <keepEmptyFile>true</keepEmptyFile>
             </revapi.reporter.json>