Drop hostname in codec test #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the 127.0.0.1 in the codec test to make the test ipv6 compliant.
|
friendly ping? |
|
Seems this is causing some CI build breaks. Reverting. |
|
I'd strongly suggest questioning the setup of your CI tests if this change breaks them... ;) but ¯_(ツ)_/¯ |
|
Seems listening on all addresses, and then trying to dial onto an ipv6 address fails on go 1.7 and go 1.8. See https://travis-ci.org/ugorji/go We really should only listen on the loopback address (localhost), so as not to possibly fall into this situation, and also so as not to deal with firewall issues and accepting connections from outside. See golang/go#18806 (for when fix for dialing to an addr without ipv6 configured on the machine was put in place). Will revert, or adjust the code. |
ugorji
added a commit
that referenced
this pull request
Jun 28, 2018
This ensures that - net.Dial works just fine on go 1.7 and 1.8 - firewall concerns do not come up, because the server is listening for connections outside local machine Updates #247 - with aim to revert the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the 127.0.0.1 in the codec test to make the test ipv6 compliant.
(it will no longer be listening on localhost explicitly, i'm happy to revert this if you're uncomfortable with that).