Skip to content

Commit

Permalink
Remove prove test plugin
Browse files Browse the repository at this point in the history
One reason this is being removed is in the spirit of dogfooding:
if one wants to use a test harness they should use the Raku one
which allows us to get back structured information.

Another reason is this plugin makes it difficult to pass in the
includes paths. Previous we were just setting RAKULIB, but that
is causing issues since we changed to using a staging installation
workflow.
  • Loading branch information
ugexe committed Nov 2, 2023
1 parent d8b73d2 commit 7c06c75
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 167 deletions.
6 changes: 2 additions & 4 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ test_script:
- raku -I. xt/repository.rakutest
- raku -I. xt/install.rakutest

# test explicitly via `prove t/*` and `raku t/foo.rakutest && raku t/bar.rakutest`
# both should work, since all our CI envs have prove
- raku -I. bin/zef --debug --/tap-harness --/prove --raku-test test .
- raku -I. bin/zef --debug --/tap-harness --prove --/raku-test test .
# test zef test
- raku -I. bin/zef --debug --raku-test test .

# run relative local path test + install
- raku -I. bin/zef --debug install .
Expand Down
6 changes: 2 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ variables:
raku -I. xt/repository.rakutest
raku -I. xt/install.rakutest
# test explicitly via `prove t/*` and `raku t/foo.rakutest && raku t/bar.rakutest`
# both should work, since all our CI envs have prove
raku -I. bin/zef --debug --/tap-harness --/prove --raku-test test .
raku -I. bin/zef --debug --/tap-harness --prove --/raku-test test .
# test zef test
raku -I. bin/zef --debug test .
# run relative local path test + install
raku -I. bin/zef --debug install .
Expand Down
1 change: 0 additions & 1 deletion META6.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@

"Zef::Service::Shell::LegacyBuild" : "lib/Zef/Service/Shell/LegacyBuild.rakumod",
"Zef::Service::Shell::Test" : "lib/Zef/Service/Shell/Test.rakumod",
"Zef::Service::Shell::prove" : "lib/Zef/Service/Shell/prove.rakumod",
"Zef::Service::Shell::unzip" : "lib/Zef/Service/Shell/unzip.rakumod",
"Zef::Service::Shell::tar" : "lib/Zef/Service/Shell/tar.rakumod",
"Zef::Service::Shell::curl" : "lib/Zef/Service/Shell/curl.rakumod",
Expand Down
3 changes: 3 additions & 0 deletions lib/Zef/CLI.rakumod
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ package Zef::CLI {
note 'DEPRECATED: --depsonly is deprecated, please use --deps-only instead';
take '--deps-only'
}
elsif $arg eq '--prove' || $arg eq '--/prove' {
note "DEPRECATED: $arg will be ignored: The prove plugin has been removed and $arg may issue an error in the future.";
}
else {
take $arg
}
Expand Down
2 changes: 1 addition & 1 deletion lib/Zef/Service/Shell/Test.rakumod
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class Zef::Service::Shell::Test does Tester {
method test(IO() $path, Str :@includes, Supplier :$stdout, Supplier :$stderr --> Bool:D)
Test the files ending in C<.rakutest> C<.t6> or C<.t> in the C<t/> directory of the given C<$path> using the
provided C<@includes> (e.g. C</foo/bar> or C<inst#/foo/bar>) via the C<prove> command. A C<Supplier> can be
provided C<@includes> (e.g. C</foo/bar> or C<inst#/foo/bar>) via the C<raku> command. A C<Supplier> can be
supplied as C<:$stdout> and C<:$stderr> to receive any output.
Returns C<True> if all test files exited with 0.
Expand Down
149 changes: 0 additions & 149 deletions lib/Zef/Service/Shell/prove.rakumod

This file was deleted.

4 changes: 2 additions & 2 deletions lib/Zef/Service/TAP.rakumod
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class Zef::Service::TAP does Tester {
You probably never want to use this unless its indirectly through C<Zef::Test>;
handling files and spawning processes will generally be easier using core language functionality. This
class exists to provide the means for fetching a file using the C<Tester> interfaces that the e.g. Test/prove
adapters use.
class exists to provide the means for fetching a file using the C<Tester> interfaces that the e.g. Test
adapter uses.
=head1 Methods
Expand Down
2 changes: 1 addition & 1 deletion lib/Zef/Test.rakumod
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Zef::Test does Tester does Pluggable {
# Setup with a single tester backend
my $tester = Zef::Test.new(
backends => [
{ module => "Zef::Service::Shell::prove" },
{ module => "Zef::Service::Shell::Test" },
],
);
Expand Down
4 changes: 0 additions & 4 deletions resources/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@
"module" : "Zef::Service::TAP",
"comment" : "Raku TAP::Harness adapter"
},
{
"short-name" : "prove",
"module" : "Zef::Service::Shell::prove"
},
{
"short-name" : "raku-test",
"module" : "Zef::Service::Shell::Test"
Expand Down
1 change: 0 additions & 1 deletion t/00-load.rakutest
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ subtest 'Plugins' => {
use-ok("Zef::Service::Shell::DistributionBuilder");
use-ok("Zef::Service::Shell::LegacyBuild");
use-ok("Zef::Service::Shell::Test");
use-ok("Zef::Service::Shell::prove");
use-ok("Zef::Service::Shell::unzip");
use-ok("Zef::Service::Shell::tar");
use-ok("Zef::Service::Shell::curl");
Expand Down

0 comments on commit 7c06c75

Please sign in to comment.