Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't calculate adaptive time step size for the first time step estimation #62

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

norihiro-w
Copy link
Contributor

needed to fix PETSc/TransLay2d benchmark

@WaltherM can you please review this?

I guess the estimation with adaptive information was considered for a case when 1st time step fails with a user-provided initial time step size. However current OGS is checking if this time step is repeated one or not, and will not call FirstTimeStepEstimate() anymore if it's repeated.

@hydromarc
Copy link

@norihiro-w sure, will do after my holidays in August.

@hydromarc
Copy link

@norihiro-w Looks all good, but some benchmarks are failing with this PR:

  • [FEM] 125 - UJG-HM/hm_cc_tri_s (Failed)
  • [FEM] 126 - UJG-HM/hm_dyn_tri (Failed)
  • [FEM] 128 - UJG-M/m_cc_tri_s (Failed)
  • [FEM] 129 - UJG-M/m_cc_quad_s (Failed)
  • [FEM] 135 - UJG-M/m_mises (Failed)
  • [FEM] 146 - UJG-M/creep/m_triax_lubby2 (Failed)
  • [FEM] 156 - WW-TH2M/Newton/th2m_quad (Failed)
  • [FEM] 159 - WX-M/3D_oedometer_mohr_coulomb (Failed)

How should we proceed?

@norihiro-w
Copy link
Contributor Author

these benchmarks are nothing to do with this PR and will be fixed in the TN's PR

@hydromarc
Copy link

hydromarc commented Aug 8, 2016

Ok. Then 👍 & ⏩

PS: I cannot merge this PR... don't know why...

@norihiro-w
Copy link
Contributor Author

I will merge this after running Jenkins again with the latest master.

you need to ask Lars to get permission to merge PRs

@norihiro-w norihiro-w merged commit c1b4955 into ufz:master Aug 8, 2016
@norihiro-w norihiro-w deleted the noadaptive-1st-dt branch August 8, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants