Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce positive-definite TVD methods for PBL and cumulus convective schemes #858

Merged
merged 20 commits into from
Nov 9, 2021

Conversation

rmontuoro
Copy link
Collaborator

@rmontuoro rmontuoro commented Oct 6, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR introduces positive-definite Total Variation Diminishing (TVD) mass-flux methods recently developed at NOAA/EMC (Jongil Han) to improve tracer transport in EDMF-TKE PBL schemes and SAMF cumulus convective parameterizations.

Such methods do not generate negative values for tracer mixing ratios during convective transport. The updated code may still generate very small (1.E-15) negative values during PBL mixing.

Please see ccpp-physics issue #753 and associated PR #754 for additional information.

Issue(s) addressed

Testing

The changes were tested on Hera/Intel and Orion/Intel.

Preliminary regression tests were run on Hera/Intel. Note that this PR will change the regression test baseline.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Oct 13, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@rmontuoro please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@rmontuoro please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

@junwang-noaa
Copy link
Collaborator

@rmontuoro would you please fix the format change requested by the reviewer in your ccpp physics PR #753?

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/752566945/20211108153011/ufs-weather-model
/scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20211104/GNU
Exists already. It should not yet. Please delete.
Please make changes and add the following label back:
hera-gnu-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/752566945/20211108153205/ufs-weather-model
/scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20211104/INTEL
Exists already. It should not yet. Please delete.
Please make changes and add the following label back:
hera-intel-BL

@junwang-noaa
Copy link
Collaborator

@rmontuoro please also change the BL_DATE in rt.sh to 20211108 for the new baseline.

@climbfuji
Copy link
Collaborator

@junwang-noaa I think we are ready to create new baselines. I'll add the hera-intel/gnu BL labels.

@climbfuji climbfuji added hera-gnu-BL Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Nov 8, 2021
@junwang-noaa
Copy link
Collaborator

I am running RT on dell and cray.

@github-actions github-actions bot removed the run-ci label Nov 9, 2021
@junwang-noaa junwang-noaa merged commit 49e4d99 into ufs-community:develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
6 participants