Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCPP metadata bugfixes, FMS 2021.03 updates in FV3, bug fix for IAU, bug fix for loading yaml module #782

Merged
merged 17 commits into from
Sep 10, 2021
Merged

CCPP metadata bugfixes, FMS 2021.03 updates in FV3, bug fix for IAU, bug fix for loading yaml module #782

merged 17 commits into from
Sep 10, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 1, 2021 •
edited
Loading

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR updates the submodule pointers for fv3atm and ccpp-physics for the changes described in the associated PRs below (CCPP metadata bugfixes and FV3 FMS updates + IAU bugfixes).

I also cherry-picked the bug fix to load module gftl-shared, yadyaml and mapl on hera only from @WenMeng-NOAA 's PR #773 to fix the compiler errors on Cheyenne.

No changes to the input data or the regression test results.

Issue(s) addressed

Fixes NCAR/ccpp-physics#723
Fixes #785

Testing

Regression tests were run on Gaea with Intel against the existing baselines, all tests passed (after repeating several failed tests due to timeouts).

rt_gaea_intel.log

Full regression tests will be run on all tier-1 platform when it is time to commit:

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI - 37bbf91 and f85f013

Dependencies

This was referenced Sep 1, 2021
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review September 1, 2021 20:39
@climbfuji climbfuji changed the title CCPP metadata bugfixes CCPP metadata bugfixes, FMS 2021.03 updates in FV3 Sep 2, 2021
@climbfuji climbfuji changed the title CCPP metadata bugfixes, FMS 2021.03 updates in FV3 CCPP metadata bugfixes, FMS 2021.03 updates in FV3, bug fix for IAU Sep 7, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/724633517/20210909131514/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_11776
Test cpld_restart 002 failed failed
Test cpld_restart 002 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

@climbfuji
Copy link
Collaborator Author

/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/724633517/20210909131514/ufs-weather-model

This test (cpld_restart 002) timed out. I am going to copy the logfile, rerun the failed test and if successful append to the logfile and push to the branch.

@climbfuji climbfuji added cheyenne-gnu-RT Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Sep 9, 2021
@github-actions github-actions bot removed the run-ci label Sep 9, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: RT
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/724633517/20210909093012/ufs-weather-model
Please make changes and add the following label back:
cheyenne-gnu-RT

@climbfuji
Copy link
Collaborator Author

@junwang-noaa @DeniseWorthen @DusanJovic-NOAA suddenly the compile jobs on Cheyenne fail, too:

Lmod has detected the following error: The following module(s) are unknown:
"mapl/v2.7.3-esmf820bs14"

Why did they not fail when the previous PR was merged???

@climbfuji climbfuji changed the title CCPP metadata bugfixes, FMS 2021.03 updates in FV3, bug fix for IAU CCPP metadata bugfixes, FMS 2021.03 updates in FV3, bug fix for IAU, bug fix for loading yaml module Sep 9, 2021
@github-actions github-actions bot removed the run-ci label Sep 9, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/724633517/20210909151505/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_40981
Test compile 006 failed failed
Test compile 004 failed failed
Test fv3_gsd 050 failed failed
Test fv3_gsd 050 failed in run_test failed
Test cpld_bmark_v16_nsst 012 failed failed
Test cpld_bmark_v16_nsst 012 failed in run_test failed
Test cpld_bmark_wave_v16 013 failed failed
Test cpld_bmark_wave_v16 013 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-RT

@climbfuji
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/724633517/20210909151505/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_40981
Test compile 006 failed failed
Test compile 004 failed failed
Test fv3_gsd 050 failed failed
Test fv3_gsd 050 failed in run_test failed
Test cpld_bmark_v16_nsst 012 failed failed
Test cpld_bmark_v16_nsst 012 failed in run_test failed
Test cpld_bmark_wave_v16 013 failed failed
Test cpld_bmark_wave_v16 013 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-RT

All these tests timed out again, even with a wallclock time of 60 minutes!

@climbfuji
Copy link
Collaborator Author

All logs are there, except gaea. In my manual RT run, one of the tests (cpld_bmark_v16_nsst) timed out even though I increased the wallclock time to 90 minutes! Now rerunning this one test.

@climbfuji
Copy link
Collaborator Author

Verified hash for fv3atm to be correct after the merge of the dependent PRs (e5dfdd5). Ready to merge.

@climbfuji climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Sep 10, 2021
@junwang-noaa junwang-noaa merged commit 29fa453 into ufs-community:develop Sep 10, 2021
@junwang-noaa junwang-noaa mentioned this pull request Sep 10, 2021
Closed
@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request Sep 10, 2021
Closed
@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request Sep 21, 2021
Merged
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
@gsketefian
Bug fix for calculation of number of time steps for a given WE2E test. (
14319ca 
#782)

## DESCRIPTION OF CHANGES: 
This PR fixes a bug in the way the number of time steps (`num_time_steps` in `get_WE2Etest_names_subdirs_descs.sh`) is calculated for each WE2E test when creating the CSV file containing information about the available WE2E tests.

## TESTS CONDUCTED: 
Reran the `run_WE2E_tests.sh` script (which in turn calls `get_WE2Etest_names_subdirs_descs.sh`), and a CSV file containing the adjusted numbers was successfully created.

## DOCUMENTATION:
None needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

Assignees
No one assigned
Labels
Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
5 participants
@climbfuji @BrianCurtis-NOAA @junwang-noaa @DusanJovic-NOAA @WenMeng-NOAA