Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UGWP v0 v1 combined #396

Merged
merged 44 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
1b8b311
Jan 7/2021 update UFS/WM develop by 18 commits
ValeryYudin-NOAA Jan 8, 2021
f249ca5
updates of FV3 fv3atm Jan 9
ValeryYudin-NOAA Jan 10, 2021
10dfee1
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
ValeryYudin-NOAA Jan 10, 2021
511e775
.gitmodules with ref to github.com/ValeryYudin-NOAA/fv3atm
ValeryYudin-NOAA Jan 11, 2021
c581195
updates of FV3 and tests for new ccpp/suites/suite_FV3_GFS_v16b_ugwp…
ValeryYudin-NOAA Jan 11, 2021
bafb063
RT-tests logs for ugwpv1
ValeryYudin-NOAA Jan 11, 2021
05298be
Added new logical flag do_ugwp_v0_nst_only which allows non-stationar…
mdtoyNOAA Jan 17, 2021
5948a24
Added new logical flag do_ugwp_v0_nst_only which allows non-stationar…
mdtoyNOAA Jan 17, 2021
9caf739
VY-NOAA env-nt for two RT-ugwpv1 + updated suite ugwpv1
ValeryYudin-NOAA Jan 21, 2021
a10796d
Merge branch 'unified_ugwp_jan_2021_update' of https://github.com/mdt…
climbfuji Jan 21, 2021
2c02679
UFS-W gitmodules with VY-FMS saturationWV
ValeryYudin-NOAA Jan 21, 2021
8cd5dc6
Merge branch 'develop' of https://github.com/valeryyudin-noaa/ufs-wea…
climbfuji Jan 22, 2021
609d93a
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Jan 22, 2021
10761a3
Update .gitmodules for code review and testing
climbfuji Jan 22, 2021
7d677c5
Update UGWP v1 regression tests
climbfuji Jan 26, 2021
8e5c863
Update submodule pointer for fv3atm
climbfuji Jan 26, 2021
d7b8d0f
Add UGWP v1 tests for GNU compiler, bugfix in tests/parm/ccpp_v16_c96…
climbfuji Feb 1, 2021
52506c6
Update submodule pointer for fv3atm; skip-ci
climbfuji Feb 3, 2021
c0be172
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Feb 4, 2021
7cf540c
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Feb 9, 2021
b0ebc20
Fix CICE, DATM and WW3 submodule pointers
climbfuji Feb 10, 2021
f89dac9
Update submodule pointer for fv3atm
climbfuji Feb 10, 2021
62424c0
Update submodule pointers for fv3atm and FMS
climbfuji Feb 11, 2021
3127675
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Feb 11, 2021
e4d7ef3
Bugfixes and reminders in regression test scripts
climbfuji Feb 11, 2021
e932f6d
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
climbfuji Feb 12, 2021
c3c0502
Remove tests/rt_ugwpv1.sh; skip-ci
climbfuji Feb 12, 2021
6a6721c
Fix broken ci
MinsukJi-NOAA Feb 12, 2021
09ab000
Fix compare_ncfile #296
MinsukJi-NOAA Feb 12, 2021
437457a
Merge pull request #9 from MinsukJi-NOAA/fix/ci-rt
climbfuji Feb 12, 2021
b55ea44
Update date tags in tests/rt.sh; skip-ci
climbfuji Feb 12, 2021
d099d10
Bugfixes for UGWP v1 regression tests
climbfuji Feb 12, 2021
33b0876
Yet another bugfix in tests/fv3_conf/ccpp_gfsv16_ugwpv1_run.IN
climbfuji Feb 12, 2021
8518825
More bugfixes to UGWP v1 regression tests
climbfuji Feb 12, 2021
52356e7
Final bugfixes for UGWP v1 regression tests; skip-ci
climbfuji Feb 12, 2021
bb1d782
Regression test logs for cheyenne.gnu; skip-ci
climbfuji Feb 13, 2021
c2e94e4
Regression test logs for hera.gnu, hera.intel, orion.intel; skip-ci
climbfuji Feb 13, 2021
e032ad7
Bugfixes and regression test logs for cheyenne.{intel,gnu}; skip-ci
climbfuji Feb 13, 2021
a85ee60
Regression test logs for wcoss_cray and wcoss_dell_p3; skip-ci
climbfuji Feb 14, 2021
64a7cbb
tests/rt.conf: turn off test fv3_ccpp_decomp for jet.intel
climbfuji Feb 16, 2021
675289c
Revert change to cheyenne modulefiles, update Python environment for …
climbfuji Feb 16, 2021
0ce7958
Update submodule pointer for fv3atm
climbfuji Feb 16, 2021
f99e0a2
Regression test logs for cheyenne.{gnu,intel}, gaea.intel, jet.intel
climbfuji Feb 16, 2021
44a495b
Revert change to .gitmodules and update submodule pointer for fv3atm
climbfuji Feb 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@ list(APPEND _fms_defs_public use_libMPI
if(QUAD_PRECISION)
list(APPEND _fms_defs_public ENABLE_QUAD_PRECISION)
endif()

# check gettid
include(CheckFunctionExists)
check_function_exists(gettid HAVE_GETTID)
if(HAVE_GETTID)
list(APPEND _fms_defs_public HAVE_GETTID)
endif()

target_compile_definitions(fms PUBLIC "${_fms_defs_public}")

if(32BIT)
Expand Down
712 changes: 449 additions & 263 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

2,216 changes: 1,201 additions & 1,015 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

2,236 changes: 1,211 additions & 1,025 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

712 changes: 449 additions & 263 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

2,332 changes: 1,259 additions & 1,073 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

2,298 changes: 1,280 additions & 1,018 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

2,332 changes: 1,259 additions & 1,073 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

1,996 changes: 1,091 additions & 905 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

2,314 changes: 1,250 additions & 1,064 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions tests/ci/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ fi

if [ $BUILD = "true" ]; then

sed -i -e '/affinity.c/d' ../../CMakeLists.txt

sudo docker build --build-arg test_name=$TEST_NAME \
--build-arg build_case=$BUILD_CASE \
--no-cache \
Expand Down
18 changes: 13 additions & 5 deletions tests/compare_ncfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,20 @@
from netCDF4 import Dataset

with Dataset(sys.argv[1]) as nc1, Dataset(sys.argv[2]) as nc2:
# Check if the list of variables are the same
if nc1.variables.keys()!=nc2.variables.keys():
print("Variables are different")
sys.exit(1)
sys.exit(2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use raise instead of sys.exit()


for varname in nc1.variables.keys():
diff = nc2[varname][:]-nc1[varname][:]
if (np.abs(diff)).max() != 0:
print(varname,"is different")
sys.exit(1)
# First check if each variable has the same dimension
if np.shape(nc1[varname][:])!=np.shape(nc2[varname][:]):
print(varname,"dimension is different")
sys.exit(2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise

# If dimension is the same, compare data
else:
diff = nc2[varname][:]-nc1[varname][:]

if (np.abs(diff)).max() != 0:
print(varname,"is different")
sys.exit(2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise

22 changes: 22 additions & 0 deletions tests/fv3_conf/ccpp_gfsv16_ugwpv1_run.IN
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
rm -rf INPUT RESTART
mkdir INPUT RESTART
if [ $WARM_START = .F. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/INPUT/* ./INPUT
else
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/INPUT/* ./INPUT
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/RESTART/* ./INPUT
fi
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/aerosol.dat .
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/co2historicaldata_201*.txt .
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/sfc_emissivity_idx.txt .
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/solarconstant_noaa_an.txt .
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/global_o3prdlos.f77 ./global_o3prdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/global_h2oprdlos.f77 ./global_h2oprdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/*grb .
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/*_table ./
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/nems.configure ./
cp @[INPUTDATA_ROOT]/FV3_input_data_ugwpv1/ugwp_c384_tau.nc ./ugwp_limb_tau.nc

if [ $DO_RRTMGP = .T. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_RRTMGP/* .
fi
Loading