Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to read increment files on native cubed sphere grid #2304

Conversation

DavidNew-NOAA
Copy link

@DavidNew-NOAA DavidNew-NOAA commented May 30, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR is a companion to GFDL Atmospheric Cubed Sphere PR #342 which adds the ability to read increment files on the native cubed sphere grid. Most of the technical details and motivation are in the description of that PR. It is also a companion to FV3 PR #837. This PR simply updates the hash for FV3.

Commit Message:

* UFSWM - Update FV3 submodule hash for FV3 PR #[837](https://github.com/NOAA-EMC/fv3atm/pull/837)
  * FV3 - Add namelist parameter for cubed sphere increment read and update atmos_cubed_sphere hash for GFDL Atmospheric Cubed Sphere PR #[342](https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/342)
    * atmos_cubed_sphere - Add ability to read increments from files on native cubed sphere grid

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 9, 2024

@DavidNew-NOAA I think it's good to add new namelist parameter increment_file_on_native_grid around fv_core_nml for the test cases https://github.com/DavidNew-NOAA/ufs-weather-model/tree/feature/cubed_sphere_inc/tests/parm. Default variable can be set here: https://github.com/DavidNew-NOAA/ufs-weather-model/blob/feature/cubed_sphere_inc/tests/default_vars.sh

@DavidNew-NOAA
Copy link
Author

Understood, thank you @jkbk2004

@DavidNew-NOAA DavidNew-NOAA marked this pull request as ready for review August 12, 2024 15:27
@jkbk2004
Copy link
Collaborator

@DavidNew-NOAA can you continue to sync up branches? we may combine this pr with #2388/#2389. I like to do a pre-test run before combining PRs. I think we can schedule to commit the combined PRs around Thursday or Friday.

@DavidNew-NOAA
Copy link
Author

@jkbk2004 OK, I will continue syncing. Thanks for you help

@jkbk2004
Copy link
Collaborator

@DavidNew-NOAA I see git issue with your fv3 branch.

Fetched in submodule path 'FV3', but it did not contain d7d7e80b22e9a96697632a0ab0497a70d80dbf97. Direct fetching of that commit failed.

@DavidNew-NOAA
Copy link
Author

@jkbk2004 I had a typo in my .gitmodules . I just pushed a commit to fix it

NickSzapiro-NOAA added a commit to NickSzapiro-NOAA/ufs-weather-model that referenced this pull request Aug 21, 2024
Add ability to read increment files on native cubed sphere grid ufs-community#2304
@jkbk2004
Copy link
Collaborator

merged with #2389

@jkbk2004 jkbk2004 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants