Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exchanged field names consistent between CMEPS,MOM6,CICE6 #1906

Merged
merged 130 commits into from
Oct 6, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 15, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Hercules
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

DeniseWorthen and others added 30 commits January 18, 2023 08:44
update cmeps build to implement check4nans feature using module stored in cdeps repo
@DeniseWorthen DeniseWorthen added Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Oct 5, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 5, 2023
@zach1221
Copy link
Collaborator

zach1221 commented Oct 5, 2023

Looks like there are some AWS EC2 instance issues popping up again, so you may see a failure notification from jenkins-ci but it's nothing to do with the code. I'm working to get it resolved.

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs failed

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@zach1221
Copy link
Collaborator

zach1221 commented Oct 6, 2023

@DeniseWorthen MOM6 sub-pr is merged. Please revert url, and update hash. MOM6 hash: 02d4dc455bb517b4c641c919dc6b9dc829e1e0d4

@zach1221 zach1221 merged commit b95e334 into ufs-community:develop Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent field names between CMEPS, MOM6 and CICE6
7 participants