-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
production/GFS.v16: gfsv16 physics updates #127
production/GFS.v16: gfsv16 physics updates #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add hd-parallel module to Hera.intel/fv3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post part looks good for me.
Fanglin,
Code is updated, would you please review again? Thanks
…On Tue, May 19, 2020 at 7:54 PM Fanglin Yang ***@***.***> wrote:
***@***.**** commented on this pull request.
need to add hd-parallel module to Hera.intel/fv3
------------------------------
In modulefiles/hera.intel/fv3
<#127 (comment)>
:
>
##
## load ESMF library for above compiler / MPI combination
## use pre-compiled EMSF library for above compiler / MPI combination
##
-module use -a /scratch1/NCEPDEV/nems/emc.nemspara/soft/modulefiles
-module load hdf5_parallel/1.10.6
-module load netcdf_parallel/4.7.4
-module load esmf/8.0.1bs08
+#module use -a /scratch1/NCEPDEV/nems/emc.nemspara/soft/modulefiles
+#module load hdf5_parallel/1.10.6
still need HDF module
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#127 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLUF37ECGK4E4ZKZVDRSML2JANCNFSM4NFNXFEA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine.
Please hold on creating a tag. There might be an extra change in physics. I am working with the developer to review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine for me. Need to update to official netcdf and esmf modules when they become available
* Removing use of mpp_io_mod and fms_io_mod from the dycore code. Replacing the necessary functions with fms2_io_mod functions * Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod * FV3 Documentation - formatted PDF and source files for FV3 documentation. * Documentation and defaults changes - Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9 (experimental, unsupported) scheme. * Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90 (cherry picked from commit bf0630f) * merge of latest dev work from GFDL Weather and Climate Dynamics Division (ufs-community#114) * read ak/bk from user specified files (ufs-community#115) * add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input (cherry picked from commit 3a0d35a) * FV3 Example Notebooks and cleanup of docs directory (ufs-community#117) * removed module use of INPUT_STR_LENGTH in fv_control.F90 (ufs-community#122) * add check on eta levels to ensure their monotonicity * update Jili Dong's ak/bk external input to - use the FMS ascii_read (single read/broadcast) - error check input to ensure the proper number of levels present * added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater * merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (ufs-community#127) Co-authored-by: Lauren Chilutti <[email protected]> Co-authored-by: laurenchilutti <[email protected]> Co-authored-by: lharris4 <[email protected]> Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Jili Dong <[email protected]>
* Update .gitmodules and submodule pointer for fv3atm for code review and testing * Disable cpld_debug_p8 and update baseline date * Hera gnu tests passed * Hera intel tests passed. * Jet intel tests passed. * Point FV3 to top of RRFS_dev * Add comment explaining why one test is disabled' Co-authored-by: Samuel Trahan <[email protected]>
[Community develop] Build orog and fre-nctools using source code from UFS_UTILS_develop
update gfsphysics update, postlib and parallel netcdf on hera