Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namelist variables for coupled model #411

Closed
DeniseWorthen opened this issue Feb 8, 2021 · 5 comments · Fixed by #399
Closed

add namelist variables for coupled model #411

DeniseWorthen opened this issue Feb 8, 2021 · 5 comments · Fixed by #399
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Feb 8, 2021

Description

Settings for dzmin and min_seaice should be added as configurable variables in the coupled tests.

Solution

The default value of dz_min should be 2. For the L27 tests, the value should be set to 6. This is a change in fv_core_nml.

The default value for min_seaice can be set to the current default value in the coupled model, which uses the puny value from CICE6 (1.0e-11). This is a change in gfs_physics_nml.

@DeniseWorthen DeniseWorthen added the enhancement New feature or request label Feb 8, 2021
@lharris4
Copy link

lharris4 commented Feb 8, 2021 via email

@DeniseWorthen
Copy link
Collaborator Author

You are right. I wrote the description incorrectly. The namelist variable that will be added for min_seaice will be in gfs_physics_nml.

The value of dz_min is for the FV3 dynamical core. It will be added to the fv_core_nml for the coupled model.

@yangfanglin
Copy link
Collaborator

yangfanglin commented Feb 8, 2021 via email

@climbfuji
Copy link
Collaborator

Hello. How can FV3 have a min_seaice option? FV3 is a dynamical core and has no sea ice, which is taken care of by the physics or a separate sea ice model.

I can answer this part. The physics require the host model to define the constants used to run the physics. This is part of the interoperability concept of the CCPP. Different models use (slightly) different values for physical constants, which we need to support, and most importantly we do not allow each physics scheme to define its own constants.

In addition to telling the physics which constants to use, I believe the min_seaice value is also used for coldstarts when figuring out fractional landmask related stuff (which gridpoint has ice or not, what is the fraction of ice, land, ...).

Also do not use dzmin to avoid crashes in development code. This was a quick fix intended only to address crashes in pre-production GFSv16. Developers should instead fix problems with the physics or coupler that lead to crashes. The MOM6 and SPEAR teams have spent a lot of time fixing coupled-model instabilities and their solutions should be considered first. Thanks, Lucas

@SMoorthi-emc
Copy link
Contributor

SMoorthi-emc commented Feb 8, 2021 via email

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
* Deprecating CYCL_HRS

Changes were made to all config files and scripts to use FIRST and LAST
cycle definitions to accept the cycle HH, and frequency will start from
those for all relevant computation.

* Updating docs to remove ref to CYCL_HRS

* Remove CYCL_HRS from workflow.

* Add option to run all tests.

* Fixes needed to run WE2E tests.

* Fix the failed test.

* Make specification of groups of test more flexible.

* Addressing Mike's review comments.

* Addressing Gerard's comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants