-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Adding Hercules as a Tier-1 platform #911
[develop] Adding Hercules as a Tier-1 platform #911
Conversation
All fundamental tests pass on Hercules:
|
Comprehensive tests outcomes:
community test:
|
@natalie-perlin - need to add 'hercules' as a valid machine to ./tests/build.sh (line 24) |
@natalie-perlin - Please update this branch to the latest HEAD of develop and address the conflicts in |
Another topic specific for this PR is which WE2E tests to run on Hercules. For testing purposes, after updating
A set of coverage tests will need to be added before the Jenkins label can be added to this PR. |
@MichaelLueken - please let me know if any more updates are needed! |
As @BruceKropp-Raytheon noted in his comment, the SRW App will not build in the Jenkins pipeline unless Since there is no With these two modifications, I would be able to give my approval on these changes. |
@MichaelLueken - done! |
Thanks, @natalie-perlin! I don't see the update for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed on Hercules.
As @MichaelLueken said, need to add hercules to the list of machines in tests/build.sh, line 24.
... Double-checked to verify the changes in ./tests/build.sh got recorded in GitHub! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natalie-perlin - Thank you very much for adding hercules
to the list of valid machines to use the tests/build.sh
build script on! I was able to successfully build the SRW on Hercules using the Jenkins build method. The Jenkins test script was also tested and successfully ran the coverage.hercules
test suite. Approving the work now.
@natalie I can confirm that adding hercules to ./tests/build.sh has allowed automated builds. Thank you. |
@natalie-perlin - An issue was encountered on Hercules that caused the Jenkins tests to fail to clone the repository on the machine. PSD-41 was opened with the Platform team to see if they can see what happened during the Initialize stage on Hercules. Just wanted to give you a head's up. |
The Derecho WE2E coverage tests were manually run on Derecho and all successfully passed:
|
@MichaelLueken - |
@natalie-perlin - The issue with the Jenkins tests on Hercules is that the same location is used to run the WE2E tests for both Orion and Hercules. Orion ultimately takes priority, causing the Hercules testing to fail to clone the repository. Reaching out the Platform team, they told me that running the Hercules test separately will allow the testing to successfully complete. It appears as though the epic account on Hercules is already set up to include loading a version of python. The Jenkins tests on Hercules successfully built the SRW and ran the coverage WE2E tests:
Moving forward, a second job will need to be queued manually in the pipeline, in order to run the WE2E coverage tests on Hercules (until the Platform team finds a better method, either through the use of 'dir' in the Jenkinsfile or possible updates to the Jenkins runner on either Orion or Hercules). I can move forward with merging this PR now. |
Modulefiles and other configuration files to adapt the SRW to Hercules system at MSU.
Software stacks used for testing are hdf5/1.14.0, netcdf/4.9.2-based, similar to those used in #889.
All fundamental tests successfully pass. All but one comprehensive tests pass, from the suite comprehensive.orion; failed nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Log files attached
DESCRIPTION OF CHANGES:
Add Hercules at MSU as a NOAA RDHPCS supported system
Type of change
TESTS CONDUCTED:
hera.intel
orion.intel
hercules
WE2E_summary_hercules_community.txt
gaea.intel
jet.intel
wcoss2.intel
NOAA Cloud (indicate which platform)
Jenkins
DEPENDENCIES:
Depends on #889
DOCUMENTATION:
ISSUE:
Fixes issue #885
CHECKLIST
LABELS (optional):
CONTRIBUTORS (optional):
WE2E_summary_20230916224448.txt
WE2E_summary_hercules_community.txt
WE2E_summary_hercules_comprehensive.txt