Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add USE_USER_STAGED_EXTRN_FILES: true to WE2E configurations that are missing this variable #780

Merged

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

During the extended HPSS downtime last week, it was noted that several tests were failing because the necessary staged data was not being pulled from the expected staged data locations. Upon careful inspection of the WE2E test configuration files for the tests that were failing showed that these test didn't have the USE_USER_STAGED_EXTRN_FILES: true variable set. Since the rest of the WE2E test configurations have this variable set, I have gone through and set this variable for the tests that it isn't set in.

Type of change

  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

  • hera.intel
  1. nco_grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
  2. nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
  3. community

ISSUE:

Fixes #779

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes

Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@EdwardSnyder-NOAA
Copy link
Collaborator

Ran the updated tests on Jet and they were fetching the files on disk as expected. Approving.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label May 10, 2023
@MichaelLueken
Copy link
Collaborator Author

The failure of the usual suspects:

Cheyenne GNU - nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km failing intermittently in run_post.

Hera GNU - get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS failing with the get_extrn_ics/lbcs tasks.

Hera Intel - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta failing in run_fcst due to issue #731 and grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR failing in PcpCombine due to issue #688.

Moving forward with merging this work now.

@MichaelLueken MichaelLueken merged commit cf5a0aa into ufs-community:develop May 12, 2023
@MichaelLueken MichaelLueken deleted the feature/use_user_staged branch May 12, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add USE_USER_STAGED_EXTRN_FILES: true to WE2E configurations that are missing this variable
3 participants