Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #813

Merged
merged 8 commits into from
Apr 19, 2023
Merged

Update PR template #813

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1aab7a2
Some template updates.
GeorgeGayno-NOAA Apr 17, 2023
a5d6274
Rename template.
GeorgeGayno-NOAA Apr 17, 2023
4a4e8b7
Format change.
GeorgeGayno-NOAA Apr 17, 2023
fc75f43
Add more required tests.
GeorgeGayno-NOAA Apr 17, 2023
980330e
Merge branch 'develop' into feature/pr_template
GeorgeGayno-NOAA Apr 18, 2023
3bde0c3
Minor edit.
GeorgeGayno-NOAA Apr 18, 2023
747c5bb
Revert name of template.
GeorgeGayno-NOAA Apr 18, 2023
376e883
Minor wording changes.
GeorgeGayno-NOAA Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,21 @@

- Use the "Preview" tab to see what your PR will look like when you hit "Create pull request"

# --- Delete this line and those above before hitting "Create pull request" ---
## --- Delete this line and those above before hitting "Create pull request" ---

## DESCRIPTION OF CHANGES:
One or more paragraphs describing the problem, solution, and required changes.

## TESTS CONDUCTED:
State whether the contingency tests were run or are pending, and if they were already run, state the result. If contingency test baselines need to be updated as a result of this PR, please specify the machine(s) and path(s) to the new files. Note that running the contigency tests is required for every PR and should be run at least once after all commits or changes have been made after review of the PR. Make note of the compilers used, the platform/machine, and other relevant details as necessary. Please also note whether new unit tests or updates to existing ones were required and their file names.
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

- [ ] Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2).
- [ ] Compile branch on Hera using GNU.
- [ ] Compile branch in 'Debug' mode on WCOSS2.
- [ ] Run unit tests locally on any Tier 1 machine.
- [ ] Run relevant consistency tests locally on all Tier 1 machine.

Describe any additional tests performed.

## DEPENDENCIES:
Add any links to pending PRs that are required prior to merging this PR. For example:
Expand Down