Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of required tests to PR template #811

Closed
GeorgeGayno-NOAA opened this issue Apr 14, 2023 · 0 comments · Fixed by #813
Closed

Add list of required tests to PR template #811

GeorgeGayno-NOAA opened this issue Apr 14, 2023 · 0 comments · Fixed by #813
Assignees
@GeorgeGayno-NOAA
Labels
enhancement New feature or request

Comments

@GeorgeGayno-NOAA
Copy link
Collaborator

When a PR is issued, a list of tests should be included (with checkboxes) for developers to complete. Some initial thoughts on what should be in this list.

  • Compile repository on all Tier 1 machines (Orion, Jet, Hera and WCOSS2) using Intel.
  • Compile repository on Hera using GNU.
  • Compile repository in 'Debug' mode (-DCMAKE_BUILD_TYPE='Debug')
  • Run unit tests locally (WCOSS2 or Hera).
  • Run relevant consistency tests on Tier 1 machines.
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Apr 17, 2023
@GeorgeGayno-NOAA GeorgeGayno-NOAA added the enhancement New feature or request label Apr 17, 2023
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 17, 2023
@GeorgeGayno-NOAA
Some template updates.
1aab7a2 
Fixes ufs-community#811.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Apr 17, 2023
Merged
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 17, 2023
@GeorgeGayno-NOAA
Rename template.
a5d6274 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 17, 2023
@GeorgeGayno-NOAA
Format change.
4a4e8b7 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 17, 2023
@GeorgeGayno-NOAA
Add more required tests.
fc75f43 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 18, 2023
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/pr_template
980330e 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 18, 2023
@GeorgeGayno-NOAA
Minor edit.
3bde0c3 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 18, 2023
@GeorgeGayno-NOAA
Revert name of template.
747c5bb 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 18, 2023
@GeorgeGayno-NOAA
Minor wording changes.
376e883 
Fixes ufs-community#811.
GeorgeGayno-NOAA added a commit that referenced this issue Apr 19, 2023
@GeorgeGayno-NOAA
Update PR template (#813)
ea1c4c6 
Update the 'tests conducted' portion of the template to include a
checklist of required tests before merging.

Fixes #811.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PR template GeorgeGayno-NOAA/UFS_UTILS
1 participant
@GeorgeGayno-NOAA