Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In chgres_cube, increase character length of string array containing grid file names #708

Closed
gsketefian opened this issue Oct 27, 2022 · 1 comment · Fixed by #814
Closed
Assignees
Labels
bug Something isn't working

Comments

@gsketefian
Copy link
Contributor

DESCRIPTION:

In chgres_cube, in file model_grid.F90, the array containing the names of the grid tile files is declared as follows:

character(len=25)                 :: grid_files(num_tiles)

In the SRW App (ufs-srweather-app), the name of the grid file can exceed 25 characters when the grid gets very fine (e.g. 1km or less) and the C-resolution goes into 5 digits, e.g. a file name of C10010_grid.tile7.halo4.nc, which is 26 characters.

SOLUTION:

Change the declaration of the grid_files array to have a longer string length, e.g. 50 characters:

character(len=50)                 :: grid_files(num_tiles)

I have tested this and it works for the specific case described above.

@GeorgeGayno-NOAA GeorgeGayno-NOAA added the bug Something isn't working label Oct 27, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 17, 2023
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Apr 17, 2023
@GeorgeGayno-NOAA
Copy link
Collaborator

Branch at 91049dc was tested on Jet. All chgres regression tests passed. Will issue PR.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 18, 2023
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 19, 2023
GeorgeGayno-NOAA added a commit that referenced this issue Apr 19, 2023
Increase the length of the character string variable that holds the
target 'grid' files so it can work with grids finer than C9999. 

Fixes #708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants