Render current-user profile picture/display name in chat screen (290) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SettingsStore.ts to store/provide update functions for user display name, profile picture index, and profile hex color. Changed SettingsScreen.tsx to allow dynamic updates to each value. In ChatMessage.tsx, allowed rendering of the stored display name, profile picture, profile color. Moved icon paths from SettingsScreen.tsx to new icons.ts file.
Added changes that should allow different users to render separate profile information within chat messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Issue #254 and updated version of pull request #304 based on requested changes.
Original pull request updated SettingsStore.ts to store/provide update functions for user display name, profile picture index, and profile hex color. Changed SettingsScreen.tsx to allow dynamic updates to each value. In ChatMessage.tsx, allowed rendering of the stored display name, profile picture, profile color. Moved icon paths from SettingsScreen.tsx to new icons.ts file.
New pull request makes it so that user and those the user is speaking to can update their displayName, profilePicIndex, and profileColor independently of the user. Done through changes to Message.ts, Props.ts, and further changes to the files in the first pull request.