Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple square detection initialized #1270

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

AlexanderWangY
Copy link

Added simple script to detect a square in an image. Also includes two AI generated test images (although we will need to collect more real images when testing)

@AlexanderWangY AlexanderWangY merged commit a26b723 into dock_color_detection Sep 5, 2024
1 of 4 checks passed
@cbrxyz
Copy link
Member

cbrxyz commented Sep 5, 2024

This is a good start! Great job on creating a color square detector! Just remember to install pre-commit for future PRs (pre-commit install should do it, otherwise check out the software docs). And, remember that environmental conditions will influence things like angles, lighting, occlusion, etc. which will likely test edge cases of your detector. It might be better to consider training an ML model (which Daniel can help with, when he is available/around) rather than using classical CV. Nonetheless, great start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants